[messageport] Add regression integration tests#1043
Merged
seungsoo47 merged 2 commits intoJun 18, 2026
Merged
Conversation
Add 5 integration test cases covering previously untested public API: - LocalPort.registered reflects the register/unregister lifecycle. - LocalPort.register throws when the port is already registered. - LocalPort.unregister is a no-op when the port is not registered and is safe to call repeatedly. - Round-trip an empty string message. - Round-trip a nested collection (list and map) message. This is a Tizen-exclusive plugin with no upstream package. Test-only change, recorded under the existing NEXT changelog entry without a version bump. Validated on a Raspberry Pi 4 device and the TV emulator: 19 passed, 0 failed.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds five integration tests to messageport_test.dart covering the LocalPort lifecycle and additional message types (empty string and nested collections), and updates the changelog. The review feedback suggests using addTearDown in the lifecycle tests to ensure the local port is unregistered even if an assertion fails, preventing potential test pollution.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…tests Register the LocalPort cleanup with addTearDown in the lifecycle tests so the port is always unregistered even if an assertion fails mid-test, preventing leaked registrations from accumulating across tests. Validated on a Raspberry Pi 4 device: 19 passed, 0 failed.
JSUYA
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 5 integration test cases covering previously untested public API:
This is a Tizen-exclusive plugin with no upstream package. Test-only change, recorded under the existing NEXT changelog entry without a version bump. Validated on a Raspberry Pi 4 device and the TV emulator: 19 passed, 0 failed.